[compiler-rt] r215708 - [ASan/Win] Remove a hack that seems not to be required with VS2013 anymore

Hans Wennborg hwennborg at google.com
Mon Aug 18 13:32:47 PDT 2014


On Mon, Aug 18, 2014 at 1:08 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> Oh, vs2012... Sure, _MSC_VER SGTM.  Can you please add it?  I don't have
> vs2012 around to test.

Added in r215932.

> 19 авг. 2014 г. 0:05 пользователь "Hans Wennborg" <hwennborg at google.com>
> написал:
>
>>
>> http://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library
>>
>> On Fri, Aug 15, 2014 at 6:45 AM, Timur Iskhodzhanov <timurrrr at google.com>
>> wrote:
>> > Author: timurrrr
>> > Date: Fri Aug 15 08:45:23 2014
>> > New Revision: 215708
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=215708&view=rev
>> > Log:
>> > [ASan/Win] Remove a hack that seems not to be required with VS2013
>> > anymore
>> >
>> > Modified:
>> >     compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc
>> >
>> > Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc?rev=215708&r1=215707&r2=215708&view=diff
>> >
>> > ==============================================================================
>> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc
>> > (original)
>> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc Fri Aug
>> > 15 08:45:23 2014
>> > @@ -22,10 +22,6 @@
>> >  #include <stdio.h>
>> >  #include <stdarg.h>
>> >
>> > -#if SANITIZER_WINDOWS && !defined(va_copy)
>> > -# define va_copy(dst, src) ((dst) = (src))
>> > -#endif
>>
>> I think VS2012 is stills supposed to be supported, and it's what's
>> used to build the weekly snapshots and releases. I've put this back in
>> r215930. Maybe we should guard it on _MSC_VER?
>>
>> Thanks,
>> Hans




More information about the llvm-commits mailing list