[polly] r215832 - Diagnostic: Provide end-user message for non-affine loop bound errors
Andreas Simbuerger
simbuerg at fim.uni-passau.de
Sun Aug 17 03:09:16 PDT 2014
Author: simbuerg
Date: Sun Aug 17 05:09:15 2014
New Revision: 215832
URL: http://llvm.org/viewvc/llvm-project?rev=215832&view=rev
Log:
Diagnostic: Provide end-user message for non-affine loop bound errors
Added:
polly/trunk/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll
Modified:
polly/trunk/include/polly/ScopDetectionDiagnostic.h
polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp
Modified: polly/trunk/include/polly/ScopDetectionDiagnostic.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopDetectionDiagnostic.h?rev=215832&r1=215831&r2=215832&view=diff
==============================================================================
--- polly/trunk/include/polly/ScopDetectionDiagnostic.h (original)
+++ polly/trunk/include/polly/ScopDetectionDiagnostic.h Sun Aug 17 05:09:15 2014
@@ -627,6 +627,9 @@ class ReportLoopBound : public RejectRea
// The non-affine loop bound.
const SCEV *LoopCount;
+ // A copy of the offending loop's debug location.
+ const DebugLoc Loc;
+
public:
ReportLoopBound(Loop *L, const SCEV *LoopCount);
@@ -641,6 +644,7 @@ public:
//@{
virtual std::string getMessage() const override;
virtual const DebugLoc &getDebugLoc() const override;
+ virtual std::string getEndUserMessage() const override;
//@}
};
Modified: polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp?rev=215832&r1=215831&r2=215832&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp (original)
+++ polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp Sun Aug 17 05:09:15 2014
@@ -393,7 +393,8 @@ bool ReportIndEdge::classof(const Reject
// ReportLoopBound.
ReportLoopBound::ReportLoopBound(Loop *L, const SCEV *LoopCount)
- : RejectReason(rrkLoopBound), L(L), LoopCount(LoopCount) {
+ : RejectReason(rrkLoopBound), L(L), LoopCount(LoopCount),
+ Loc(L->getStartLoc()) {
++BadLoopBoundForScop;
}
@@ -402,15 +403,16 @@ std::string ReportLoopBound::getMessage(
L->getHeader()->getName();
}
-const DebugLoc &ReportLoopBound::getDebugLoc() const {
- const BasicBlock *BB = L->getHeader();
- return BB->getTerminator()->getDebugLoc();
-}
+const DebugLoc &ReportLoopBound::getDebugLoc() const { return Loc; }
bool ReportLoopBound::classof(const RejectReason *RR) {
return RR->getKind() == rrkLoopBound;
}
+std::string ReportLoopBound::getEndUserMessage() const {
+ return "Failed to derive an affine function from the loop bounds.";
+}
+
//===----------------------------------------------------------------------===//
// ReportFuncCall.
Added: polly/trunk/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll?rev=215832&view=auto
==============================================================================
--- polly/trunk/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll (added)
+++ polly/trunk/test/ScopDetectionDiagnostics/ReportLoopBound-01.ll Sun Aug 17 05:09:15 2014
@@ -0,0 +1,89 @@
+; RUN: opt %loadPolly -pass-remarks-missed="polly-detect" -polly-detect-track-failures -polly-detect -analyze < %s 2>&1| FileCheck %s
+
+; void f(int A[], int n) {
+; for (int i = 0; i < A[n]; i++)
+; A[i] = 0;
+; }
+
+; CHECK: remark: ReportLoopBound-01.c:2:8: The following errors keep this region from being a Scop.
+; CHECK: remark: ReportLoopBound-01.c:2:8: Failed to derive an affine function from the loop bounds.
+; CHECK: remark: ReportLoopBound-01.c:3:5: Invalid Scop candidate ends here.
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @f(i32* %A, i32 %n) {
+entry:
+ br label %entry.split
+
+entry.split: ; preds = %entry
+ tail call void @llvm.dbg.value(metadata !{i32* %A}, i64 0, metadata !13), !dbg !14
+ tail call void @llvm.dbg.value(metadata !{i32 %n}, i64 0, metadata !15), !dbg !16
+ tail call void @llvm.dbg.value(metadata !17, i64 0, metadata !18), !dbg !20
+ %idxprom = sext i32 %n to i64, !dbg !21
+ %arrayidx = getelementptr inbounds i32* %A, i64 %idxprom, !dbg !21
+ %0 = load i32* %arrayidx, align 4, !dbg !21
+ %cmp3 = icmp sgt i32 %0, 0, !dbg !21
+ br i1 %cmp3, label %for.body.lr.ph, label %for.end, !dbg !21
+
+for.body.lr.ph: ; preds = %entry.split
+ br label %for.body, !dbg !22
+
+for.body: ; preds = %for.body.lr.ph, %for.body
+ %indvar = phi i64 [ 0, %for.body.lr.ph ], [ %indvar.next, %for.body ]
+ %arrayidx2 = getelementptr i32* %A, i64 %indvar, !dbg !24
+ %1 = add i64 %indvar, 1, !dbg !24
+ %inc = trunc i64 %1 to i32, !dbg !21
+ store i32 0, i32* %arrayidx2, align 4, !dbg !24
+ tail call void @llvm.dbg.value(metadata !{null}, i64 0, metadata !18), !dbg !20
+ %2 = load i32* %arrayidx, align 4, !dbg !21
+ %cmp = icmp slt i32 %inc, %2, !dbg !21
+ %indvar.next = add i64 %indvar, 1, !dbg !21
+ br i1 %cmp, label %for.body, label %for.cond.for.end_crit_edge, !dbg !21
+
+for.cond.for.end_crit_edge: ; preds = %for.body
+ br label %for.end, !dbg !25
+
+for.end: ; preds = %for.cond.for.end_crit_edge, %entry.split
+ ret void, !dbg !27
+}
+
+declare void @llvm.dbg.declare(metadata, metadata)
+
+declare void @llvm.dbg.value(metadata, i64, metadata)
+
+attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone }
+
+!llvm.dbg.cu = !{!0}
+!llvm.module.flags = !{!10, !11}
+!llvm.ident = !{!12}
+
+!0 = metadata !{i32 786449, metadata !1, i32 12, metadata !"clang version 3.6.0 ", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata !3, metadata !2, metadata !2, metadata !"", i32 1} ; [ DW_TAG_compile_unit ] [test/ScopDetectionDiagnostic/ReportLoopBound-01.c] [DW_LANG_C99]
+!1 = metadata !{metadata !"ReportLoopBound-01.c", metadata !"test/ScopDetectionDiagnostic/"}
+!2 = metadata !{}
+!3 = metadata !{metadata !4}
+!4 = metadata !{i32 786478, metadata !1, metadata !5, metadata !"f", metadata !"f", metadata !"", i32 1, metadata !6, i1 false, i1 true, i32 0, i32 0, null, i32 256, i1 false, void (i32*, i32)* @f, null, null, metadata !2, i32 1} ; [ DW_TAG_subprogram ] [line 1] [def] [f]
+!5 = metadata !{i32 786473, metadata !1} ; [ DW_TAG_file_type ] [test/ScopDetectionDiagnostic/ReportLoopBound-01.c]
+!6 = metadata !{i32 786453, i32 0, null, metadata !"", i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !7, i32 0, null, null, null} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
+!7 = metadata !{null, metadata !8, metadata !9}
+!8 = metadata !{i32 786447, null, null, metadata !"", i32 0, i64 64, i64 64, i64 0, i32 0, metadata !9} ; [ DW_TAG_pointer_type ] [line 0, size 64, align 64, offset 0] [from int]
+!9 = metadata !{i32 786468, null, null, metadata !"int", i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ] [int] [line 0, size 32, align 32, offset 0, enc DW_ATE_signed]
+!10 = metadata !{i32 2, metadata !"Dwarf Version", i32 4}
+!11 = metadata !{i32 2, metadata !"Debug Info Version", i32 1}
+!12 = metadata !{metadata !"clang version 3.6.0 "}
+!13 = metadata !{i32 786689, metadata !4, metadata !"A", metadata !5, i32 16777217, metadata !8, i32 0, i32 0} ; [ DW_TAG_arg_variable ] [A] [line 1]
+!14 = metadata !{i32 1, i32 12, metadata !4, null}
+!15 = metadata !{i32 786689, metadata !4, metadata !"n", metadata !5, i32 33554433, metadata !9, i32 0, i32 0} ; [ DW_TAG_arg_variable ] [n] [line 1]
+!16 = metadata !{i32 1, i32 21, metadata !4, null}
+!17 = metadata !{i32 0}
+!18 = metadata !{i32 786688, metadata !19, metadata !"i", metadata !5, i32 2, metadata !9, i32 0, i32 0} ; [ DW_TAG_auto_variable ] [i] [line 2]
+!19 = metadata !{i32 786443, metadata !1, metadata !4, i32 2, i32 3, i32 0, i32 0} ; [ DW_TAG_lexical_block ] [test/ScopDetectionDiagnostic/ReportLoopBound-01.c]
+!20 = metadata !{i32 2, i32 12, metadata !19, null}
+!21 = metadata !{i32 2, i32 8, metadata !19, null}
+!22 = metadata !{i32 2, i32 8, metadata !23, null}
+!23 = metadata !{i32 786443, metadata !1, metadata !19, i32 2, i32 8, i32 1, i32 1} ; [ DW_TAG_lexical_block ] [test/ScopDetectionDiagnostic/ReportLoopBound-01.c]
+!24 = metadata !{i32 3, i32 5, metadata !19, null}
+!25 = metadata !{i32 2, i32 8, metadata !26, null}
+!26 = metadata !{i32 786443, metadata !1, metadata !19, i32 2, i32 8, i32 2, i32 2} ; [ DW_TAG_lexical_block ] [test/ScopDetectionDiagnostic/ReportLoopBound-01.c]
+!27 = metadata !{i32 4, i32 1, metadata !4, null}
More information about the llvm-commits
mailing list