[llvm] r215826 - Added a table for intrinsics on X86.

Chandler Carruth chandlerc at google.com
Sun Aug 17 02:16:49 PDT 2014


On Sun, Aug 17, 2014 at 2:00 AM, Elena Demikhovsky <
elena.demikhovsky at intel.com> wrote:

> +std::map < unsigned, IntrinsicData> IntrWithChainMap;
> +void InitIntrinsicsWithChain() {
> +  static bool Initialized = false;
> +  if (Initialized)
> +    return;
>

What?

This is a thread-unsafe global variable with a static initializer, and
everything... then using a weird initialized boolean in the function?

Please revert, and send out this patch for code review so that people can
discuss different approaches. I'm convinced that the code as-is isn't the
correct design or code for this problem.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140817/7a691915/attachment.html>


More information about the llvm-commits mailing list