[polly][PATCH] Diagnostic: Provide end-user message for non-affine loop bound errors

Tobias Grosser tobias at grosser.es
Sat Aug 16 10:49:30 PDT 2014


On 15/08/2014 00:04, Andreas Simbuerger wrote:
> ---
>   include/polly/ScopDetectionDiagnostic.h            |  4 +
>   lib/Analysis/ScopDetectionDiagnostic.cpp           | 12 +--
>   .../ScopDetectionDiagnostics/ReportLoopBound-01.ll | 89 ++++++++++++++++++++++
>   3 files changed, 100 insertions(+), 5 deletions(-)
>   create mode 100644 test/ScopDetectionDiagnostics/ReportLoopBound-01.ll

Nice, thanks a lot.

One comment. I would avoid to mention 'upper bound' in the error 
message. I believe we also complicated lower bounds can cause this 
error. What about:

"Failed to express number of loop iterations as affine function"

(This is possibly also not optimal, so feel free to improve)

Also, thanks a lot for the very nice test case.

Tobias



More information about the llvm-commits mailing list