[PATCH] Make use of isAtLeastRelease/Acquire in the ARM/AArch64 backends

Robin Morisset morisset at google.com
Fri Aug 15 17:33:15 PDT 2014


================
Comment at: lib/Target/AArch64/AArch64InstrAtomics.td:32
@@ -31,3 +31,1 @@
   AtomicOrdering Ordering = cast<AtomicSDNode>(N)->getOrdering();
-  assert(Ordering != AcquireRelease && "unexpected load ordering");
-  return Ordering == Acquire || Ordering == SequentiallyConsistent;
----------------
JF Bastien wrote:
> Robin Morisset wrote:
> > JF Bastien wrote:
> > > You probably want to keep this assert. Although it is weird that subsequent code doesn't have similar asserts (I'd expect consistency in all-asserts or none).
> > I removed this assert because of this lack of consistency, but I can add it back (and to the other functions maybe) if you want.
> Removing it seems fine to me since the other locations don't have similar asserts.
Then can you accept the revision please? Thanks.

http://reviews.llvm.org/D4937






More information about the llvm-commits mailing list