[PATCH] [ELF] LLD does not create a record in the .dynsym if a strong symbol defined in the executable file replaces a weak symbol from a shared library.

Shankar Easwaran shankare at codeaurora.org
Fri Aug 15 14:44:46 PDT 2014


On 8/15/2014 3:48 PM, Nick Kledzik wrote:
> Good point.  Rather than a set <const DefinedAtom*>, ELFLinkingContext can just maintain
> a StringSet.  That is, record the atom’s name instead of its address.  That approach would
> not work for anonymous (unnamed) atoms or scopeTranslationUnit (static) atoms.  But in
> this case, the atoms are named and scopeGlobal, so it will work.
Nick,

I would prefer the data not saved in the LinkingContext as the whole 
information is lost on what data was dynamically exported when using 
--output-filetype=YAML.

The dynamic export functionality cannot be tested outside the Reader.

Having a reference type inbuilt into the linker would be much more 
useful, IMO.

PS: My mailbox synced all mails only now for some reason, and so my late 
reply :)

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list