[PATCH] Fix PR17239 by changing the semantics of the RemainingArgsClass Option kind
Reid Kleckner
rnk at google.com
Fri Aug 15 13:24:59 PDT 2014
>>! In D4899#8, @rafaelauler wrote:
> Hi Rafael,
>
> Regarding the generality of this approach, I agree that it seems more that what is needed. However, I ran into a problem when trying to implement a simpler way. Consider the following situation (in my test case):
>
> clang-cl /link @response.txt /align...(some linker flag)
>
> If we implement the "null" approach here, we would insert a null after response.txt and would prematurely end which arguments "/link" get.
It appears we don't need to support "/link @t.rsp". MSVC doesn't support nested response files, and when cl invokes the linker, it uses a response file. It does not expand response files after /link, so you end up with a nested response file and link.exe errors out because it thinks it's an input file.
http://reviews.llvm.org/D4899
More information about the llvm-commits
mailing list