[PATCH] Fix PR17239 by changing the semantics of the RemainingArgsClass Option kind

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Aug 15 11:47:45 PDT 2014


This seems more than what is needed.

If all that we need is to find the end of the response file following an argument, can't we just change  ExpandResponseFiles to include a null in NewArgv every time a response file ends?

That way the processing of /link would claim all arguments until the null.  Regular processing in cl::ParseCommandLineOptions would just ignore the null entries. There are only 3 calls to ExpandResponseFiles. One llvm, one in clang and one in lld.

http://reviews.llvm.org/D4899






More information about the llvm-commits mailing list