PATCH: SelectionDAG: Fix incorrect lowering of CONCAT_VECTOR

Tom Stellard tom at stellard.net
Thu Aug 14 12:04:14 PDT 2014


On Thu, Aug 14, 2014 at 10:31:41AM -0700, Matt Arsenault wrote:
> On 08/08/2014 05:39 PM, Tom Stellard wrote:
> >+    // where a build vector has operand types larger than the destination
> >+    // element type. e.g. v4i16 = BUILD_VECTOR i32, i32, i32, i32
> >+    if (!SrcVT.isVector() && EltVT.bitsLT(SrcVT)) {
> Although this comment is sort of misleading since you don't exactly
> have a build_vector typed v4i16 with i32 operands

I just added that to clarify what situation this if statement was
meant to handle.  It was confusing to me when I first looked at it.

-Tom



More information about the llvm-commits mailing list