[polly] r215466 - [Refactor] Cleanup runtime code generation
Tobias Grosser
tobias at grosser.es
Wed Aug 13 11:08:38 PDT 2014
On 13/08/2014 02:35, Johannes Doerfert wrote:
> Author: jdoerfert
> Date: Tue Aug 12 13:35:54 2014
> New Revision: 215466
>
> URL: http://llvm.org/viewvc/llvm-project?rev=215466&view=rev
> Log:
> [Refactor] Cleanup runtime code generation
>
> + Use regexp in two test case.
> + Refactor the runtime condition build function
Hi Johannes,
this patch broke our LNT tests, could you please revert it.
Here the broken builder:
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-codegen-isl
To reproduce:
mysandbox/bin/lnt runtest --verbose nt --sandbox nt --cc
build/bin/clang --cxx build/bin/clang++ --without-llvm --test-suite
test-suite/ --no-machdep-info pollyperf-O3-polly --multisample=1
--mllvm=-polly --cflag=-Xclang --cflag=-load --cflag=-Xclang
--cflag=/home/grosser/Projects/polly/build/lib/LLVMPolly.so
--only-test=MultiSource/Benchmarks/MallocBench/gs
--mllvm=-polly-code-generator=isl
I run this with your patch and with your patch reverted, the latter
passes the first one fails.
Even though I OKed the original commit, I think we need to be more
careful the next time. We should try harder to separate stylistic
commits from commits that may possibly change the behaviour of the
program. At best, we have individual, easily understandable style
improvements, instead of general purpose 'cleanup' patches.
Cheers,
Tobias
More information about the llvm-commits
mailing list