[PATCH] [aarch64] Fix the problem of using a "//" as comment start.

Francesco Petrogalli francesco.petrogalli at arm.com
Wed Aug 13 07:14:48 PDT 2014


Hello folks out there,
here is my first patch to llvm. Bon appetit.

Franesco

    The AsmLexer has been implemented with the assumption that the
    CommentString defined as a const char * in MCAsmInfo.h should be
    defined as a single char. In AArch64 CommentString is defined as "//",
    so that even "/" was defined as comment start.
    
    Regression tests has been introduced in test/MC/AsmParser/AsmLexer/,
    and some of the darwin regression tests has been adapted to the "##"
    CommentString.

http://reviews.llvm.org/D4882

Files:
  include/llvm/MC/MCParser/AsmLexer.h
  lib/MC/MCParser/AsmLexer.cpp
  test/MC/AsmParser/AsmLexer/aarch64-comment.s
  test/MC/AsmParser/AsmLexer/aarch64-not-a-comment.s
  test/MC/AsmParser/macros-darwin.s
  test/MC/MachO/tlv-reloc.s
  test/MC/MachO/x86_32-optimal_nop.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4882.12445.patch
Type: text/x-patch
Size: 7830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140813/6626ba5a/attachment.bin>


More information about the llvm-commits mailing list