[PATCH] move LLVM_VERSION_PATCH to llvm-config.h

Chandler Carruth chandlerc at google.com
Tue Aug 12 16:28:56 PDT 2014


On Tue, Aug 12, 2014 at 4:25 PM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> On Tue, Aug 12, 2014 at 04:18:47PM -0700, Chandler Carruth wrote:
> > On Tue, Aug 12, 2014 at 3:41 PM, Dylan Noblesmith <nobled at dreamwidth.org
> >
> > wrote:
> >
> > > Since clients shouldn't (and shouldn't be able to)
> > > include LLVM's internal config.h header, it was
> > > effectively completely useless there.
> > >
> > > Put it where LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR
> > > already are instead.
> > >
> >
> > But, the whole point was that it is *different*. There shouldn't ever be
> > API breaking changes in a patch release? The point of patch releases were
> > to apply minimal, targeted fixes for critical bugs. Clients shouldn't be
> > aware of them IMO.
>
> They might still want to be able to workaround bugs fixed by those
> targeted patches for critical bugs :)


As the fix might arrive with the same SO name, I would not expect this to
be done via macros.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140812/b0f62527/attachment.html>


More information about the llvm-commits mailing list