[PATCH][AVX512] Handle valign masking intrinsic via C++ lowering

Robert Khasanov rob.khasanov at gmail.com
Tue Aug 12 06:19:42 PDT 2014


LGTM


2014-08-08 10:32 GMT+04:00 Adam Nemet <anemet at apple.com>:

> Hi,
>
> I think that this will scale better in most cases than adding a Pat<> for
> each
> mapping from the intrinsic DAG to the intruction (i.e. rri, rrik, rrikz).
>  We
> can just lower to the SDNode and have the resulting DAG be matches by the
> DAG
> patterns.
>
> Alternatively (long term), we could keep the Pat<>s but generate them via
> the
> new AVX512_masking multiclass.  The difficulty is that in order to
> formulate
> that we would have to concatenate DAGs in tablegen.  Currently this is only
> supported if the operators of the input DAGs are identical.
>
> Please let me know if it looks good.
>
> Adam
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140812/0501000d/attachment.html>


More information about the llvm-commits mailing list