[llvm] r215224 - Delete dead code. NFC.

Rafael Espíndola rafael.espindola at gmail.com
Mon Aug 11 11:36:56 PDT 2014


On 11 August 2014 14:11, Dimitar Dobrev <dpldobrev at yahoo.com> wrote:
>
>
>     I completely agree with you. This was exactly my point - however, you said it better. I am also ready to contribute to this additional support. In fact, I've already sent a patch for the COFF case at ⚙ D4727 Fixed the getting of names and look-up entries of DLL imports. I have also fixed needed_library_begin and I am ready to send another patch if this function is restored to the code base.
>

I commented on D4727. Again, I don't think getLibraryNext as it was
should be added again. The summary of the issues were

* Declared as general, but aborts if the object is not ELF.
* Not used.

If you have a patch fixing *both* issues, please send it for review.
For example, a patch adding an iterator for used libraries only on ELF
and changing llvm-objdump's  ELFDumper to use is probably fine (but
needs review).

Cheers,
Rafael




More information about the llvm-commits mailing list