[llvm] r215224 - Delete dead code. NFC.

[Dimitar Dobrev]

    Thanks for the tip. It can be done but this way it's still more cumbersome than it used to be. It was just a loop with a call to getPath inside. Now I have to find the proper ELF type (because ELFFile is a template class) and then manually extract the dependencies. Those wrappers were extremely useful in delegating all this work. Are you sure there's no way we can restore these functions?

    Regards,
    Dimitar
    



On Monday, August 11, 2014 3:07 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
 


On 11 August 2014 10:59, Dimitar Dobrev <dpldobrev at yahoo.com> wrote:

>
>     Hello Raphael,
>
>     I am Dimitar Dobrev, the person Joao refers to. I need
> needed_library_begin/end to obtain the dependencies of ELF libraries.
> needed_library_begin has a bug I was able to fix today (I'll be glad to send
> a patch) just to find out it's been deleted. Since I wasn't able to find
> their exact equivalents in your suggestion of ELFFile, would it be a problem
> to restore those? I think it's useful being able to read the dependencies of
> a library. I'd be glad to tell you about our (mine and Joao's) particular
> use case if you're interested.

You can find the ELFFile code in the bits the patch is deleting.  The
interface was forwarding to ELFFile and asserting on COFF and MachO,
which doesn't seem like a very useful addition over using ELFFile
directly.

You can also check  ELFDumper<ELFT>::printNeededLibraries() in llvm-readobj.

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140811/94903c6c/attachment.html>