[llvm] r215228 - DebugInfo: Recommit (reverted in r215217, originally committed in r215157) the assertion that no argument variable is overwritten by subsequent argument variables.

David Blaikie dblaikie at gmail.com
Fri Aug 8 10:12:36 PDT 2014


Author: dblaikie
Date: Fri Aug  8 12:12:35 2014
New Revision: 215228

URL: http://llvm.org/viewvc/llvm-project?rev=215228&view=rev
Log:
DebugInfo: Recommit (reverted in r215217, originally committed in r215157) the assertion that no argument variable is overwritten by subsequent argument variables.

This turned up a bug in clang where arguments were emitted with
duplicate argument numbers (see r215227).

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=215228&r1=215227&r2=215228&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Fri Aug  8 12:12:35 2014
@@ -1144,6 +1144,7 @@ bool DwarfDebug::addCurrentFnArgument(Db
   // arguments does the function have at source level.
   if (ArgNo > Size)
     CurrentFnArguments.resize(ArgNo * 2);
+  assert(!CurrentFnArguments[ArgNo - 1]);
   CurrentFnArguments[ArgNo - 1] = Var;
   return true;
 }





More information about the llvm-commits mailing list