[PATCH][CodeGen] Add missing intrinsic lowering for sin, cos and ceil

[Josh Klontz]

Committed revision 215209.


On Tue, Aug 5, 2014 at 9:06 AM, Josh Klontz <josh.klontz at gmail.com> wrote:

> Pinging Evan
>
>
> On Mon, Aug 4, 2014 at 8:51 PM, Duncan P. N. Exon Smith <
> dexonsmith at apple.com> wrote:
>
>> This LGTM.  You'll have to ping the code owner to get it into
>> the 3.5 branch though.
>>
>> > On 2014-Aug-04, at 17:40, Josh Klontz <josh.klontz at gmail.com> wrote:
>> >
>> > Duncan,
>> >
>> > Attached is an updated patch with f64 tests added. f128 was not added
>> as libffi does not seem to support this type (LLVM ERROR: Type could not be
>> mapped for use with libffi.).
>> >
>> > I agree it's odd that `lli` lowers libc & libm functions through a
>> different interface than the native backend.
>> >
>> > v/r,
>> > Josh
>> >
>> >
>> > On Mon, Aug 4, 2014 at 5:57 PM, Duncan P. N. Exon Smith <
>> dexonsmith at apple.com> wrote:
>> > Huh, I'm surprised that IntrinsicLowering is only used in the
>> interpreter.
>> > I don't know `lli` too well, so anyone else should feel free to chime in
>> > here.
>> >
>> > I did notice that your test only checks the f32 versions -- I think it
>> > should exercise the full matrix.
>> >
>> > > On 2014-Aug-04, at 14:38, Josh Klontz <josh.klontz at gmail.com> wrote:
>> > >
>> > > Duncan,
>> > >
>> > > Attached is an updated patch with a test case. Note, this required
>> extending lit to recognize `LLVM_ENABLE_FFI`.
>> > >
>> > > v/r,
>> > > Josh
>> > >
>> > >
>> > > On Mon, Aug 4, 2014 at 2:02 PM, Duncan P. N. Exon Smith <
>> dexonsmith at apple.com> wrote:
>> > > Testcase?
>> > >
>> > > > On 2014-Jul-30, at 05:00, Josh Klontz <josh.klontz at gmail.com>
>> wrote:
>> > > >
>> > > > Ping. CC'ing code owner and release manager.
>> > > > -Josh
>> > > >
>> > > >
>> > > > On Wed, Jul 23, 2014 at 12:01 PM, Josh Klontz <
>> josh.klontz at gmail.com> wrote:
>> > > > This was discovered when trying to run lli on a function with an
>> llvm.cos.f32 intrinsic. Hopefully this can get applied to the 3.5 branch as
>> well. Thanks!
>> > > > -Josh
>> > > >
>> > > > _______________________________________________
>> > > > llvm-commits mailing list
>> > > > llvm-commits at cs.uiuc.edu
>> > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> > >
>> > >
>> > > <patch.diff>
>> >
>> >
>> > <patch.diff>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140808/d3f92007/attachment.html>