[llvm] r215032 - Add the -mcpu= option to llvm-objdump for use with the disassemblers.

[Michel Dänzer]

On 07.08.2014 08:24, Kevin Enderby wrote:
> Author: enderby
> Date: Wed Aug  6 18:24:41 2014
> New Revision: 215032
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=215032&view=rev
> Log:
> Add the -mcpu= option to llvm-objdump for use with the disassemblers.
> Also make the disassembler created with the Mach-O parser (the -m option)
> pick up the Target specific attributes specified with -mattr option.

This change broke make check for me:

FAIL: LLVM :: tools/llvm-objdump/macho-mattr-arm.test (10229 of 11361)
******************** TEST 'LLVM :: tools/llvm-objdump/macho-mattr-arm.test' FAILED ********************
Script:
--
/home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-mc < /home/daenzer/src/llvm-git/llvm/test/tools/llvm-objdump/macho-mattr-arm.test -triple armv8-apple-darwin10 -mattr=+fp-armv8 -filetype=obj -o - | /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-objdump -d -m -mattr=+fp-armv8 - | /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/FileCheck /home/daenzer/src/llvm-git/llvm/test/tools/llvm-objdump/macho-mattr-arm.test
--
Exit Code: 2

Command Output (stderr):
--
/home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-mc: : error: unable to get target for 'armv8-apple-darwin10', see --version and --triple.
llvm-objdump: /home/daenzer/src/llvm-git/llvm/include/llvm/Support/ErrorOr.h:242: storage_type *llvm::ErrorOr<std::unique_ptr<llvm::object::MachOObjectFile, std::default_delete<llvm::object::MachOObjectFile> > >::getStorage() [OtherT = std::unique_ptr<llvm::object::MachOObjectFile, std::default_delete<llvm::object::MachOObjectFile> >]: Assertion `!HasError && "Cannot get value when an error exists!"' failed.
0  libLLVM-3.6svn.so 0x00007f9e757f05d5 llvm::sys::PrintStackTrace(_IO_FILE*) + 37
1  libLLVM-3.6svn.so 0x00007f9e757f0eb3
2  libpthread.so.0   0x00007f9e750078d0
3  libc.so.6         0x00007f9e74015407 gsignal + 55
4  libc.so.6         0x00007f9e740167e8 abort + 328
5  libc.so.6         0x00007f9e7400e526
6  libc.so.6         0x00007f9e7400e5d2
7  llvm-objdump      0x000000000040df73
8  llvm-objdump      0x0000000000410944
9  libc.so.6         0x00007f9e74001b45 __libc_start_main + 245
10 llvm-objdump      0x0000000000405cc5
Stack dump:
0.	Program arguments: /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-objdump -d -m -mattr=+fp-armv8 - 
FileCheck error: '-' is empty.

--

********************
FAIL: LLVM :: tools/llvm-objdump/macho-mcpu-arm.test (10230 of 11361)
******************** TEST 'LLVM :: tools/llvm-objdump/macho-mcpu-arm.test' FAILED ********************
Script:
--
/home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-mc < /home/daenzer/src/llvm-git/llvm/test/tools/llvm-objdump/macho-mcpu-arm.test -triple thumbv7-apple-darwin -mcpu=cortex-a7 -filetype=obj | /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-objdump -triple thumbv7-apple-darwin10 -m -d -mcpu=cortex-a7 - | /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/FileCheck /home/daenzer/src/llvm-git/llvm/test/tools/llvm-objdump/macho-mcpu-arm.test
--
Exit Code: 2

Command Output (stderr):
--
/home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-mc: : error: unable to get target for 'thumbv7-apple-darwin', see --version and --triple.
llvm-objdump: /home/daenzer/src/llvm-git/llvm/include/llvm/Support/ErrorOr.h:242: storage_type *llvm::ErrorOr<std::unique_ptr<llvm::object::MachOObjectFile, std::default_delete<llvm::object::MachOObjectFile> > >::getStorage() [OtherT = std::unique_ptr<llvm::object::MachOObjectFile, std::default_delete<llvm::object::MachOObjectFile> >]: Assertion `!HasError && "Cannot get value when an error exists!"' failed.
0  libLLVM-3.6svn.so 0x00007f869b7185d5 llvm::sys::PrintStackTrace(_IO_FILE*) + 37
1  libLLVM-3.6svn.so 0x00007f869b718eb3
2  libpthread.so.0   0x00007f869af2f8d0
3  libc.so.6         0x00007f8699f3d407 gsignal + 55
4  libc.so.6         0x00007f8699f3e7e8 abort + 328
5  libc.so.6         0x00007f8699f36526
6  libc.so.6         0x00007f8699f365d2
7  llvm-objdump      0x000000000040df73
8  llvm-objdump      0x0000000000410944
9  libc.so.6         0x00007f8699f29b45 __libc_start_main + 245
10 llvm-objdump      0x0000000000405cc5
Stack dump:
0.	Program arguments: /home/daenzer/src/llvm-git/llvm/build-amd64/Release+Debug+Asserts/bin/llvm-objdump -triple thumbv7-apple-darwin10 -m -d -mcpu=cortex-a7 - 
FileCheck error: '-' is empty.

--

********************
Testing Time: 53.14s
********************
Failing Tests (2):
    LLVM :: tools/llvm-objdump/macho-mattr-arm.test
    LLVM :: tools/llvm-objdump/macho-mcpu-arm.test

  Expected Passes    : 7267
  Expected Failures  : 48
  Unsupported Tests  : 4044
  Unexpected Failures: 2
Makefile:102: recipe for target 'check-local' failed
make[1]: *** [check-local] Error 1
make[1]: Leaving directory '/home/daenzer/src/llvm-git/llvm/build-amd64/test'
/home/daenzer/src/llvm-git/llvm/Makefile.rules:1794: recipe for target 'check' failed
make: *** [check] Error 2



-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer