[PATCH] Debug info: Cleanup collectChangingRegs

[David Blaikie]

The isDebugValue checking seems like a somewhat arbitrary case of
pre-filtering. Does it have an observable performance impact? Is there
some more general test we can do here that would catch more cases of
MIs that don't have register definitions? (to have a bigger impact and
make the intent of the code clearer - it's not about skipping debug
values, it's about skipping non-defining instructions)

On Tue, Aug 5, 2014 at 11:25 PM, Frédéric Riss <friss at apple.com> wrote:
> Noticed while working on DbgValueHistoryCalculator.cpp.
>
>     Cleanup collectChangingRegs
>
>     The handling of the epilogue is best expressed as an early exit and
>     there is no reason to look for register defs in DbgValue MIs.
>
> OK to apply?
>