[PATCH] Test failures in GCC ASan testsuite on ARM Linux due to FP format mismatch between libsanitizer and GCC.

Yury Gribov tetra2005 at gmail.com
Wed Aug 6 03:30:56 PDT 2014


================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.cc:65
@@ -44,3 +64,3 @@
   size = 1;
-  uhwptr *frame = (uhwptr *)bp;
-  uhwptr *prev_frame = frame - 1;
+  stack_bottom = Max(stack_bottom, (uptr)&size);
+  uhwptr *frame = GetCanonicFrame(bp, stack_top, stack_bottom);
----------------
I'd still ask for bp instead of &size here.

================
Comment at: test/asan/TestCases/Linux/clang_gcc_abi.cc:30
@@ +29,3 @@
+  asm volatile("push    {r11, lr}\n\t"
+                "mov r11, sp\n\t"
+                "bl  gcc_abi\n\t"
----------------
Broken formatting.

http://reviews.llvm.org/D4692






More information about the llvm-commits mailing list