[PATCH] cmake: Remove check for files not in build list.

Matt Arsenault Matthew.Arsenault at amd.com
Tue Aug 5 18:06:51 PDT 2014


Insert a check for backup files instead. Skip files that begin with the normal "." for unix hidden files

http://reviews.llvm.org/D4581

Files:
  cmake/modules/LLVMProcessSources.cmake

Index: cmake/modules/LLVMProcessSources.cmake
===================================================================
--- cmake/modules/LLVMProcessSources.cmake
+++ cmake/modules/LLVMProcessSources.cmake
@@ -59,12 +59,18 @@
   file(GLOB globbed *.c *.cpp)
   foreach(g ${globbed})
     get_filename_component(fn ${g} NAME)
-    list(FIND LLVM_OPTIONAL_SOURCES ${fn} idx)
-    if( idx LESS 0 )
-      list(FIND listed ${fn} idx)
+
+    # Don't reject hidden files. Some editors create backups in the
+    # same directory as the file.
+    string(SUBSTRING ${fn} 0 1 first_char)
+    if(NOT ${first_char} STREQUAL ".")
+      list(FIND LLVM_OPTIONAL_SOURCES ${fn} idx)
       if( idx LESS 0 )
-        message(SEND_ERROR "Found unknown source file ${g}
+        list(FIND listed ${fn} idx)
+        if( idx LESS 0 )
+          message(SEND_ERROR "Found unknown source file ${g}
 Please update ${CMAKE_CURRENT_LIST_FILE}\n")
+        endif()
       endif()
     endif()
   endforeach()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4581.12218.patch
Type: text/x-patch
Size: 980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140806/d21fdcbf/attachment.bin>


More information about the llvm-commits mailing list