[PATCH] Initial ELF/AArch64 Support
Rui Ueyama
ruiu at google.com
Tue Aug 5 15:07:20 PDT 2014
I'm not an expert of ARM64 so maybe I'm just scratching the surface, but here are my comments.
REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h:22
@@ +21,3 @@
+ AArch64ExecutableWriter(AArch64LinkingContext &context,
+ AArch64TargetLayout<ELFT> &layout);
+
----------------
Indentation error? Please run clang-format on the files.
================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h:26
@@ +25,3 @@
+ // Add any runtime files and their atoms to the output
+ virtual bool createImplicitFiles(std::vector<std::unique_ptr<File>> &);
+
----------------
I think this function overrides ExecutableWriter::createImplicitFiles. If a member function overrides, don't write "virtual" but add "override". That applies to other functions too.
================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp:66
@@ +65,3 @@
+ llvm::dbgs() << " immlo: " << Twine::utohexstr(immlo);
+ llvm::dbgs() << " result: " << result << "\n");
+ *reinterpret_cast<llvm::support::little32_t *>(location) =
----------------
Debug leftover?
http://reviews.llvm.org/D4778
More information about the llvm-commits
mailing list