[llvm] r214880 - Partially revert r214761 that asserted that all concrete debug info variables had DIEs, due to a failure on Darwin.

David Blaikie dblaikie at gmail.com
Tue Aug 5 09:47:24 PDT 2014


Author: dblaikie
Date: Tue Aug  5 11:47:23 2014
New Revision: 214880

URL: http://llvm.org/viewvc/llvm-project?rev=214880&view=rev
Log:
Partially revert r214761 that asserted that all concrete debug info variables had DIEs, due to a failure on Darwin.

I'll work on a reduction and fix after this.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=214880&r1=214879&r2=214880&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Tue Aug  5 11:47:23 2014
@@ -797,7 +797,8 @@ void DwarfDebug::finishVariableDefinitio
   for (const auto &Var : ConcreteVariables) {
     DIE *VariableDie = Var->getDIE();
     // FIXME: There shouldn't be any variables without DIEs.
-    assert(VariableDie);
+    if (!VariableDie)
+      continue;
     // FIXME: Consider the time-space tradeoff of just storing the unit pointer
     // in the ConcreteVariables list, rather than looking it up again here.
     // DIE::getUnit isn't simple - it walks parent pointers, etc.





More information about the llvm-commits mailing list