[AArch64] FP load balancing pass for Cortex-A57

James Molloy james.molloy at arm.com
Tue Aug 5 08:49:43 PDT 2014


> What does clang-format tells you?

Exactly what I just did, it turns out. Except it put both params on the same line because they can just fit in 80 cols.

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 05 August 2014 16:42
To: James Molloy
Cc: Tim Northover; llvm-commits
Subject: Re: [AArch64] FP load balancing pass for Cortex-A57

On 5 August 2014 16:38, James Molloy <james.molloy at arm.com> wrote:
> Here's one I made earlier ;) Also known as, forgetting to SVN add my 
> test file. No wonder you asked for "more" tests! :(

Ha! Yes.

I found it weird of you sending patches without any tests... I assumed that was more as an RFC (with a full patch?)... anyway.


> I've made the formatting and dox changes you suggested too. Although I'm still not sure what the preferred way to format a lambda inside a std::sort is...

Beats me! I'm ok with that, at least it separates the lambda from the rest making it clear.

What does clang-format tells you?

cheers,
--renato







More information about the llvm-commits mailing list