[PATCH] [AArch64] Type conversion bug when anlyze compare

[Tim Northover]

Shouldn't you be able to produce a test for this? It doesn't seem impossibly difficult to distil the key features from the SPEC case.

I think the change also needs better documentation. You're changing the meaning of CmpValue here: no-one can ever rely on any nonzero value after this commit. That might be OK, since we don't want to anyway right now, but I think it needs to be clear and blow up horribly.

Perhaps making sure CmpValue is always 0 or 1, and asserting that in optimizeCompare? (With an appropriate comments about the limitation and why it was introduced).

Cheers.

Tim.

http://reviews.llvm.org/D4771