[compiler-rt] r213668 - [ASan/Win tests] Bring back -GS- as SEH tests fail otherwise

[Timur Iskhodzhanov]

The FIXME is addressed in r214861.

2014-07-22 20:09 GMT+04:00 Timur Iskhodzhanov <timurrrr at google.com>:
> Author: timurrrr
> Date: Tue Jul 22 11:09:11 2014
> New Revision: 213668
>
> URL: http://llvm.org/viewvc/llvm-project?rev=213668&view=rev
> Log:
> [ASan/Win tests] Bring back -GS- as SEH tests fail otherwise
>
> Modified:
>     compiler-rt/trunk/test/asan/TestCases/Windows/dll_seh.cc
>     compiler-rt/trunk/test/asan/TestCases/Windows/seh.cc
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Windows/dll_seh.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Windows/dll_seh.cc?rev=213668&r1=213667&r2=213668&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Windows/dll_seh.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Windows/dll_seh.cc Tue Jul 22 11:09:11 2014
> @@ -4,7 +4,7 @@
>  // build a large project using "clang-cl -fallback -fsanitize=address".
>  //
>  // RUN: %clang_cl_asan -O0 %p/dll_host.cc -Fe%t
> -// RUN: cl -LD -c %s -Fo%t.obj
> +// RUN: cl -LD -GS- -c %s -Fo%t.obj
>  // RUN: %clang_cl_asan -LD -O0 %s -Fe%t.dll %t.obj
>  // RUN: %run %t %t.dll
>
>
> Modified: compiler-rt/trunk/test/asan/TestCases/Windows/seh.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Windows/seh.cc?rev=213668&r1=213667&r2=213668&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Windows/seh.cc (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Windows/seh.cc Tue Jul 22 11:09:11 2014
> @@ -3,7 +3,8 @@
>  // the rest is built with Clang.  This represents the typical scenario when we
>  // build a large project using "clang-cl -fallback -fsanitize=address".
>  //
> -// RUN: cl -c %s -Fo%t.obj
> +// FIXME: Investigate why -GS- is required.
> +// RUN: cl -GS- -c %s -Fo%t.obj
>  // RUN: %clangxx_asan -o %t.exe %s %t.obj
>  // RUN: %run %t.exe
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits