[llvm] r214709 - [mips] Add assembler support for '.set mipsX'.

[Daniel Sanders]

Yes you're right. Fixed in r214715.

From: cardologist at gmail.com [mailto:cardologist at gmail.com] On Behalf Of Joey Gouly
Sent: 04 August 2014 13:51
To: Daniel Sanders
Cc: Commit Messages and Patches for LLVM
Subject: Re: [llvm] r214709 - [mips] Add assembler support for '.set mipsX'.

> Modified: llvm/trunk/include/llvm/MC/MCSubtargetInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSubtargetInfo.h?rev=214709&r1=214708&r2=214709&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/MC/MCSubtargetInfo.h (original)
> +++ llvm/trunk/include/llvm/MC/MCSubtargetInfo.h Mon Aug  4 07:20:00 2014
> @@ -65,6 +65,10 @@ public:
>      return FeatureBits;
>    }
>
> +  /// setFeatureBits - Set the feature bits.
> +  ///
> +  void setFeatureBits(uint64_t _FeatureBits) { FeatureBits = _FeatureBits; }

Shouldn't this be FeatureBits_?
In the n337.pdf of C++11,  17.6.4.3.2 says that names beginning with _ and then a capital letter are reserved.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140804/e20062e4/attachment.html>