Valgrind buildbot failures

[Tilmann Scheller]

Hi Justin,

yeah, I agree that this is definitely not a bidirectional iterator (even
though it claims to be).

I like your patch, I strongly prefer this solution over the previous
proposal of making the the original iterator return a value rather than a
reference.

Regards,

Tilmann

-----Original Message-----
From: Justin Bogner [mailto:justin at justinbogner.com] On Behalf Of Justin
Bogner
Sent: Monday, August 04, 2014 12:19 AM
To: Tilmann Scheller
Cc: 'David Blaikie'; llvm-commits at cs.uiuc.edu
Subject: Re: Valgrind buildbot failures

I don't think this kind of stashing iterator is even a valid bidirectional
iterator. Nobody needs this to be bidirectional anyway (everything iterates
once through in one direction or the other) so I guess the simplest fix is
to split this into two input iterators like in the attached.

WDYT?