[PATCH] Support: Provide a function to get the home directory of an arbitrary user

Zachary Turner zturner at google.com
Fri Aug 1 11:03:42 PDT 2014


Not sure it's possible without putting an #ifdef in the cross-platform
Path.h, which would be ugly.  The other alternative I guess is to just kill
the entire patch, and use the platform-specific logic in whatever tool
needs it.


On Fri, Aug 1, 2014 at 10:59 AM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Fri, Aug 1, 2014 at 1:49 PM, Zachary Turner <zturner at google.com> wrote:
> > Talked about it with rnk some, I think maybe we can just delete the
> entire
> > windows implementation of this function and have it return false.  These
> > directories on Windows are going to be ACLed to the teeth and we won't be
> > able to read or even traverse an arbitrary user's home directory anyway,
> so
> > there's kind of no point in doing this.  So, proposal: Unix
> implementation
> > remains the same, Windows implementation is one line that returns false.
> >
> > Thoughts?
>
> I think the entire API is a broken concept on Windows. Without the
> token for the logged on user, the concept of getting their home
> directory is broken. So I'm all for making this a UNIX-only piece of
> functionality, but I'm not keen on having an exposed cross-platform
> API which can never be implemented properly on Windows.
>
> Any way we could make it UNIX-only?
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/6b62fac9/attachment.html>


More information about the llvm-commits mailing list