[PATCH] [lit] Add --show-xfail flag to LIT.
Daniel Dunbar
daniel at zuster.org
Fri Aug 1 09:47:45 PDT 2014
LGTM
- Daniel
On Thu, Jul 31, 2014 at 11:57 PM, Eric Fiselier <eric at efcs.ca> wrote:
> Hi ddunbar,
>
> This patch add a --show-xfail flag. If this flag is specified then each
> xfail test will be printed to output.
> When it is not given xfail tests are ignored. Ignoring xfail tests is the
> current behavior.
>
> This flag is meant to mirror the --show-unsupported flag that was recently
> added.
>
> http://reviews.llvm.org/D4750
>
> Files:
> docs/CommandGuide/lit.rst
> utils/lit/lit/main.py
>
> Index: docs/CommandGuide/lit.rst
> ===================================================================
> --- docs/CommandGuide/lit.rst
> +++ docs/CommandGuide/lit.rst
> @@ -88,6 +88,10 @@
>
> Show the names of unsupported tests.
>
> +.. option:: --show-xfail
> +
> + Show the names of tests that were expected to fail.
> +
> .. _execution-options:
>
> EXECUTION OPTIONS
> Index: utils/lit/lit/main.py
> ===================================================================
> --- utils/lit/lit/main.py
> +++ utils/lit/lit/main.py
> @@ -44,6 +44,7 @@
>
> shouldShow = test.result.code.isFailure or \
> (self.opts.show_unsupported and test.result.code.name ==
> 'UNSUPPORTED') or \
> + (self.opts.show_xfail and test.result.code.name == 'XFAIL')
> or \
> (not self.opts.quiet and not self.opts.succinct)
> if not shouldShow:
> return
> @@ -173,6 +174,9 @@
> group.add_option("", "--show-unsupported", dest="show_unsupported",
> help="Show unsupported tests",
> action="store_true", default=False)
> + group.add_option("", "--show-xfail", dest="show_xfail",
> + help="Show tests that were expected to fail",
> + action="store_true", default=False)
> parser.add_option_group(group)
>
> group = OptionGroup(parser, "Test Execution")
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/4ad783b4/attachment.html>
More information about the llvm-commits
mailing list