[llvm] r214517 - [PowerPC] PR20280 - Slots for byval parameters are not immutable
Ulrich Weigand
ulrich.weigand at de.ibm.com
Fri Aug 1 07:35:58 PDT 2014
Author: uweigand
Date: Fri Aug 1 09:35:58 2014
New Revision: 214517
URL: http://llvm.org/viewvc/llvm-project?rev=214517&view=rev
Log:
[PowerPC] PR20280 - Slots for byval parameters are not immutable
Found by inspection while looking at PR20280: code would mark slots
in the parameter save area where a byval parameter is passed as
"immutable". This is not correct since code is allowed to modify
byval parameters in place in the parameter save area.
Modified:
llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=214517&r1=214516&r2=214517&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Fri Aug 1 09:35:58 2014
@@ -2688,7 +2688,7 @@ PPCTargetLowering::LowerFormalArguments_
int FI;
if (HasParameterArea ||
ArgSize + ArgOffset > LinkageSize + Num_GPR_Regs * PtrByteSize)
- FI = MFI->CreateFixedObject(ArgSize, ArgOffset, true);
+ FI = MFI->CreateFixedObject(ArgSize, ArgOffset, false);
else
FI = MFI->CreateStackObject(ArgSize, Align, false);
SDValue FIN = DAG.getFrameIndex(FI, PtrVT);
More information about the llvm-commits
mailing list