[llvm] r214514 - Simplify the code a bit with std::unique_ptr.
Rafael Espindola
rafael.espindola at gmail.com
Fri Aug 1 07:11:14 PDT 2014
Author: rafael
Date: Fri Aug 1 09:11:14 2014
New Revision: 214514
URL: http://llvm.org/viewvc/llvm-project?rev=214514&view=rev
Log:
Simplify the code a bit with std::unique_ptr.
Modified:
llvm/trunk/utils/FileCheck/FileCheck.cpp
Modified: llvm/trunk/utils/FileCheck/FileCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/FileCheck/FileCheck.cpp?rev=214514&r1=214513&r2=214514&view=diff
==============================================================================
--- llvm/trunk/utils/FileCheck/FileCheck.cpp (original)
+++ llvm/trunk/utils/FileCheck/FileCheck.cpp Fri Aug 1 09:11:14 2014
@@ -631,7 +631,7 @@ struct CheckString {
///
/// \param PreserveHorizontal Don't squash consecutive horizontal whitespace
/// characters to a single space.
-static MemoryBuffer *CanonicalizeInputFile(MemoryBuffer *MB,
+static MemoryBuffer *CanonicalizeInputFile(std::unique_ptr<MemoryBuffer> MB,
bool PreserveHorizontal) {
SmallString<128> NewFile;
NewFile.reserve(MB->getBufferSize());
@@ -657,12 +657,8 @@ static MemoryBuffer *CanonicalizeInputFi
++Ptr;
}
- // Free the old buffer and return a new one.
- MemoryBuffer *MB2 =
- MemoryBuffer::getMemBufferCopy(NewFile.str(), MB->getBufferIdentifier());
-
- delete MB;
- return MB2;
+ return MemoryBuffer::getMemBufferCopy(NewFile.str(),
+ MB->getBufferIdentifier());
}
static bool IsPartOfWord(char c) {
@@ -837,7 +833,7 @@ static bool ReadCheckFile(SourceMgr &SM,
// If we want to canonicalize whitespace, strip excess whitespace from the
// buffer containing the CHECK lines. Remove DOS style line endings.
- MemoryBuffer *F = CanonicalizeInputFile(FileOrErr.get().release(),
+ MemoryBuffer *F = CanonicalizeInputFile(std::move(FileOrErr.get()),
NoCanonicalizeWhiteSpace);
SM.AddNewSourceBuffer(F, SMLoc());
@@ -1272,7 +1268,7 @@ int main(int argc, char **argv) {
// Remove duplicate spaces in the input file if requested.
// Remove DOS style line endings.
MemoryBuffer *F =
- CanonicalizeInputFile(File.release(), NoCanonicalizeWhiteSpace);
+ CanonicalizeInputFile(std::move(File), NoCanonicalizeWhiteSpace);
SM.AddNewSourceBuffer(F, SMLoc());
More information about the llvm-commits
mailing list