[PATCH] PR20234 - [SLP Vectorizer] Canonicalize tree operands of commutitive binary operands.

[Chad Rosier]

>>! In D4680#21, @eeckstein wrote:
> Hi Chad,
> 
> I'm sorry that I didn't see your patch before.
> I'm currently also working on the SLPVectorizer and my patch is in the final review phase. It's about improving the scheduling.
> This is a different issue than what you handle in your patch, but still there is one "conflict":
> 
> My new scheduling algorithm is more general and made some heuristics obsolete which - like your approach - relied on the instruction numbering. So I could remove the instruction numbering at all.
> 
> Now I looked in detail what problem you solve in your test case. Here the original problem is that the load instructions are in the wrong order, so that they are not recognised as consecutive loads.
> 
> I attached a new patch which is a more general solution and does not rely on instruction numbering.
> Please take a look at it. If it proves to work well, I'd like to replace your change with this algorithm. This would make my life easier for my other patch :-)
> 
> For reference I also attached the my scheduling-patch (it's based on an earlier revision).
> 
> Thanks and sorry for replying so late,
> Erik
> 
> - {F120137, layout=link}
> - {F120138, layout=link}
> - {F120136, layout=link}

Hi Erik,
I added you to the CC list because I noticed you were working on the SLP vectorizer as well.  I suspect your patch is the more robust solution I was referring to in the original email. ;)  Does the test case in this patch still work with your patch?  If so, I have no problem with you reverting this patch and applying yours.  Please just add my test case to your patch.  If not, I would like to get the test passing with your patch.

 Chad

http://reviews.llvm.org/D4680