[PATCH] [asan-assembly-instrumentation] Added instrumentation for REP MOVS.
Yuri Gorshenin
ygorshenin at chromium.org
Wed Jul 30 12:12:57 PDT 2014
PTAL
================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:181
@@ +180,3 @@
+ InstrumentMOVSImpl(AccessSize, Ctx, Out);
+ return;
+}
----------------
Evgeniy Stepanov wrote:
> Don't really need a return here.
Done.
================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:620
@@ -489,3 +619,3 @@
const MCInst &Inst, OperandVector &Operands, MCContext &Ctx,
const MCInstrInfo &MII, MCStreamer &Out) {}
----------------
Evgeniy Stepanov wrote:
> Don't you need to emit the original instruction here?
>
Yes, I need. Fixed + fixed test.
http://reviews.llvm.org/D4719
More information about the llvm-commits
mailing list