[llvm] r214144 - llvm-uselistorder: Add -num-shuffles option

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Jul 30 10:23:10 PDT 2014


> On 2014-Jul-29, at 19:45, Sean Silva <chisophugis at gmail.com> wrote:
> 
> 
> 
> 
> On Tue, Jul 29, 2014 at 11:56 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> > On 2014-Jul-29, at 09:43, Sean Silva <chisophugis at gmail.com> wrote:
> >
> > Some random comments:
> >
> > 1. Looks like the comment at the top of the file is copypasta from opt.
> 
> r214187, thanks for noticing.
> 
> > 2. The comment at the top of this file should describe the purpose of this tool. From skimming the code it looks like some sort of fuzzer.
> 
> Did something quick in r214187 -- sufficient or do you think there should be
> more?
> 
> Maybe some information about invocation and basic usage?
> 

I added a more complete description in r214317, but left invocation and
usage to -help (IMO the header comment will invariable be out of date).

> > 3. The name is incredibly ambiguous; could it at least have a verb in it? It seems like it is a fuzzer that verifies that use-lists correctly round-trip through bitcode. Is there a better name? Maybe something with "verify" in it? (a long-ish name for a specialized tool like this wouldn't seem that out of place).
> 
> Here are two options:
> 
>   - verify-uselistorder
>   - llvm-verify-uselistorder
> 
> Either of those sound better to you?
> 
> Both sound fine. Take your pick.

=> verify-uselistorder in r214318.



More information about the llvm-commits mailing list