[PATCH] LLVM CFL Alias Analysis -- Supporting Data Structures

George Burgess IV gbiv at google.com
Tue Jul 29 16:25:29 PDT 2014


Updated code to better match LLVM style, addressed most/all of hfinkel's and sanjoy's concerns. 

Responses to a few of the higher-level comments:
hfinkel:
> What does it mean to "keep information on the notion of" somthing? Does this means it manages the state associated with state remapping?
Comment updated in an effort to better describe what I'm doing. :)
> What's the reason for using the term "remapping" to describe the set unioning operation? There seem to be better choices (union, join, group; maybe some term related to proxying would be more appropriate?).
It seemed like it fit what was happening well enough, because our goal is to effectively treat the "remapped" set as deleted, and a proxy a different set. I do like the terms "ProxyFor" and "Proxies" more though, so I'll swap to one of the two in the next rev.

sanjoy:
> {Terminology comment}
Agreed. The notion of an aliasingExternal will be removed in the next revision, because, in implementing interprocedural analysis (coming soon to a code review near you), a more generic approach was necessary. I haven't quite settled on a name for it yet, so if you have any suggestions for names of properties that are transitive in the "low" direction, I'd be happy to hear them. :)
> Why only update start here? ...
It only updated start because doing so was correct and simple to code. I see your point though, so I swapped over to updating everything.

http://reviews.llvm.org/D4550

Files:
  lib/Analysis/StratifiedSets.h
  lib/Analysis/WeightedBidirectedGraph.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4550.12000.patch
Type: text/x-patch
Size: 24848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140729/aadb46e5/attachment.bin>


More information about the llvm-commits mailing list