[Polly][Refactor] IslAst [6/7]

[Johannes Doerfert]

>> OK. Thanks for clarifying.
:)

>> I was assuming this, but I am still a little confused by the code (also
by the old one). Specifically, I try to understand if there is a difference
between an innermost-parallel loop and an innermost and parallel loop and
wonder which has been implemented before, what is implemented today.
There should not be a difference. I think (very strongly):
               Old
New
  InnermostParallel <= equiv. =>  innermost && parallel
 OutermostParallel <= equiv. => !innermost && parallel

>> I am specifically interested to try a couple more test cases that show
this difference. As this was not here in the original code, it is obviously
not your fault, but I would use this opportunity to make this stupidly
obvious.
Difference between what exactly? The one you mentioned above? What exactly
do you want to test?

>> I was just trying to compile and run this patch and it seems to not apply
cleanly. Specifically, the part of the diff that tries to remove a line
'assert(Info && "Post order visit assumes annotated for nodes")'
>> does not apply. Do I need any other patch to be able to apply and test
this code? Do you happen to have a patch that applies cleanly?
I don't know how this happened by it's my bad. Attached a rebased version.

--

Johannes Doerfert
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Refactor-Use-isParallel-and-isInnermost.patch
Type: application/octet-stream
Size: 9618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140729/b9b8b1eb/attachment.obj>