[llvm] r214135 - IR: Optimize size of use-list order shuffle vectors

Chandler Carruth chandlerc at gmail.com
Tue Jul 29 10:44:40 PDT 2014


On Tue, Jul 29, 2014 at 10:33 AM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> Given that this is all still experimental, I'm not at the stage of
> profiling this.  I'd used `SmallVector` without really thinking about
> it, and then when I noticed the error I replaced it with something
> strictly better.  If you feel strongly enough that this needs to be
> reverted immediately (well, switch to `std::vector`), let me know.
>
> Otherwise, it's likely to change anyway, since shuffles don't need
> nearly this much memory (see my way-too-long-to-read llvmdev post).
>

If this code isn't likely to stay, and can't even be profiled, *please*
stop tuning it and introducing needless abstractions. What is it even doing
in tree??? =[[[[

I really dislike committing "throw-away" code. It wastes reviewers time
(see this thread), it wastes contributors time (see chapuni's fixes to your
patches to keep the bots green) and it makes it really hard to see the
actual code intended.

Either pull this out of tree, or treat it as real code and respond to the
code review? =[
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140729/0bc99c47/attachment.html>


More information about the llvm-commits mailing list