[PATCH] fix for PR20354 - Miscompile of fabs due to vectorization

Pete peter_cooper at apple.com
Tue Jul 29 08:51:37 PDT 2014


Hi Sanjay

Oh yeah, I see the fix you've made for the mask, and i totally agree that fix is correct, and required.

My point is that because of !VT.isVector(), we shouldn't even be hitting the code inside that branch right now.  So if you're getting miscompilations, its due to bad code elsewhere.

Or is the point that you're only getting miscompilations *after* you remove !VT.isVector(), and thats what you're fixing?

Thanks.

http://reviews.llvm.org/D4633






More information about the llvm-commits mailing list