[PATCH] Add alignment value to allowsUnalignedMemoryAccess
Jon Roelofs
jonathan at codesourcery.com
Mon Jul 28 06:53:16 PDT 2014
================
Comment at: include/llvm/Target/TargetLowering.h:780
@@ -779,3 +779,3 @@
/// of the specified type in the given address space. If true, it also returns
/// whether the unaligned memory access is "fast" in the third argument by
/// reference. This is used, for example, in situations where an array
----------------
> "in the third argument by reference"
This comment needs a little attention... the type of the parameter is 'bool*' and not 'bool&'. Can you fix the comment while you're here? Something like "in the fourth argument, if provided and non-null".
Also, I'm with Hal on this one. 'Unaligned' is the terminology normally used for this sort of thing. Why are you renaming this?
http://reviews.llvm.org/D4684
More information about the llvm-commits
mailing list