[PATCH] Test failures in GCC ASan testsuite on ARM Linux due to FP format mismatch between libsanitizer and GCC.

Renato Golin renato.golin at linaro.org
Mon Jul 28 04:14:37 PDT 2014


I agree with tests, no regressions on current tests don't mean much.

cheers,
--renato

================
Comment at: lib/sanitizer_common/sanitizer_stacktrace.cc:53
@@ +52,3 @@
+    return bp_prev;
+#ifdef __arm__
+  --bp_prev;
----------------
It's not clear how this will separate a GCC logic from LLVM one (or rather, different FP logics), on ARM.

It'll also make the second IsValidFrame() call redundant on anything _but_ ARM. Maybe you should move all of it inside the #ifdef block?

  #ifdef __arm__
    if (IsValidFrame((uptr)bp_prev[0], stack_top, stack_bottom))
      return bp_prev;
    --bp_prev;
  #endif
    return bp_prev;

http://reviews.llvm.org/D4692






More information about the llvm-commits mailing list