[Polly] Replace the Dependences::isParallelDimension by the IslAst parallelism check

[Johannes Doerfert]

What do you guys think?

On 07/24, Johannes Doerfert wrote:
> I think I got this now. I will test it tonight myself if nobody tells me it
> is fine as it is.
> 
> --
> 
> Johannes Doerfert
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
> 
> 
> -----Original Message-----
> From: Tobias Grosser [mailto:tobias at grosser.es] 
> Sent: Wednesday, July 23, 2014 10:48 PM
> To: Johannes Doerfert; llvm-commits at cs.uiuc.edu
> Subject: Re: [Polly] Replace the Dependences::isParallelDimension by the
> IslAst parallelism check
> 
> On 24/07/2014 01:40, Johannes Doerfert wrote:
> > This time I attached the patch.
> 
> I just applied this patch and I get the following compile error:
> 
> /home/grosser/Projects/polly/git/tools/polly/lib/CodeGen/CodeGeneration.cpp:
> 884:8: 
> error: member reference type 'polly::Dependences' is not a pointer
>        D->getDependences(Dependences::TYPE_RAW | Dependences::TYPE_WAW |
>        ~^
> 1 error generated
> 
> If I fix this one, many CLooG test cases fail with:
> 
> /home/grosser/Projects/polly/tools/src/cloog/isl/isl_ctx.c:245: isl_ctx
> freed, but some objects still reference it 0  libLLVMSupport.so
> 0x00007f0ac46dc1ce llvm::sys::PrintStackTrace(_IO_FILE*) + 46
> 
> I think you really need to compile and test your code before submitting (I
> know this adds overhead. If we get the OpenMP patches, we can remove the
> dependency to CLooG entierly)
> 
> I also looked over the patch. It looks like a very nice cleanup.
> 
> Cheers,
> Tobias
> 
> 


> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.26

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-the-dependences-parallelism-check-by-the-Isl.patch
Type: text/x-diff
Size: 10727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140726/a8c6fb91/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140726/a8c6fb91/attachment.sig>