[PATCH] [SROA] Fold a PHI node if all its incoming values are the same

Jingyue Wu jingyue at google.com
Fri Jul 25 21:28:35 PDT 2014


Chandler, thanks for your suggestions! I think moving the logic to SliceBuilder makes perfect sense. 

After modifying SliceBuilder::visitPHINode, I found it almost the same as visitSelectInst. Therefore, I also refactored the code to merge visitPHINode and visitSelectInst to one function. Let me know if it looks good to you.

http://reviews.llvm.org/D4659

Files:
  lib/Transforms/Scalar/SROA.cpp
  test/Transforms/SROA/phi-and-select.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4659.11909.patch
Type: text/x-patch
Size: 6239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140726/f054cb2a/attachment.bin>


More information about the llvm-commits mailing list