[patch] Start adding tests for the gold plugin

Alexey Samsonov vonosmas at gmail.com
Fri Jul 25 18:07:23 PDT 2014


lit changes look good, a couple of nits:

+def have_ld_plugin_support():
+    if not os.path.exists(config.llvm_shlib_dir + '/LLVMgold.so'):
+        return False
+

you can os.path.join(config.llvm_shlib_dir, LLVMgold.so) instead.
+if not 'ld_plugin' in  config.available_features or \
+   not 'X86' in config.root.targets:
+   config.unsupported = True

I'd prefer parens instead of backslash.



On Fri, Jul 25, 2014 at 5:43 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> Also added a test for the recent -mtattr fix.
>
> Adding Alexey Samsonov for the lit bits.
>
> On 23 July 2014 18:24, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> > And the attached patch also works when running on ppc.
> >
> > On 23 July 2014 17:41, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> >> Hi Nick,
> >>
> >> I cannot remember exactly why we never added direct tests for the gold
> >> plugin. It might be that it was uncommon to have a ld with plugin
> >> support or maybe it was just that our test infrastructure was not able
> >> to handle it.
> >>
> >> In any case, it seems that it is now fairly easy to test the plugin
> >> when the tests are run in a machine with a ld that supports plugins.
> >> The attached patch adds a simple test for a previous fix.
> >>
> >> I have tested that it works with both gold (passes) and bfd ld
> >> (unsupported) on linux.
> >>
> >> I am currently building on a non-x86 machine to test that.
> >>
> >> Cheers,
> >> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140725/1d80751a/attachment.html>


More information about the llvm-commits mailing list