[PATCH] Coverage: remove empty mapping regions

Alex Lorenz arphaman at gmail.com
Fri Jul 25 14:37:57 PDT 2014


Hi bogner, bob.wilson,

This patch removes the empty coverage mapping regions.

Those regions were produced by clang's old mapping region generation algorithm, but the new algorithm doesn't generate them.

http://reviews.llvm.org/D4677

Files:
  include/llvm/ProfileData/CoverageMapping.h
  lib/ProfileData/CoverageMappingReader.cpp
  lib/ProfileData/CoverageMappingWriter.cpp

Index: include/llvm/ProfileData/CoverageMapping.h
===================================================================
--- include/llvm/ProfileData/CoverageMapping.h
+++ include/llvm/ProfileData/CoverageMapping.h
@@ -139,10 +139,6 @@
     /// such as for a macro instantiation or #include file.
     ExpansionRegion,
 
-    /// \brief An EmptyRegion represents a source range without code,
-    /// but with a distinct counter.
-    EmptyRegion,
-
     /// \brief A SkippedRegion represents a source range with code that
     /// was skipped by a preprocessor or similar means.
     SkippedRegion
Index: lib/ProfileData/CoverageMappingReader.cpp
===================================================================
--- lib/ProfileData/CoverageMappingReader.cpp
+++ lib/ProfileData/CoverageMappingReader.cpp
@@ -160,9 +160,6 @@
         case CounterMappingRegion::CodeRegion:
           // Don't do anything when we have a code region with a zero counter.
           break;
-        case CounterMappingRegion::EmptyRegion:
-          Kind = CounterMappingRegion::EmptyRegion;
-          break;
         case CounterMappingRegion::SkippedRegion:
           Kind = CounterMappingRegion::SkippedRegion;
           break;
Index: lib/ProfileData/CoverageMappingWriter.cpp
===================================================================
--- lib/ProfileData/CoverageMappingWriter.cpp
+++ lib/ProfileData/CoverageMappingWriter.cpp
@@ -172,11 +172,6 @@
       encodeULEB128(EncodedTagExpandedFileID, OS);
       break;
     }
-    case CounterMappingRegion::EmptyRegion:
-      encodeULEB128(unsigned(I.Kind)
-                        << Counter::EncodingCounterTagAndExpansionRegionTagBits,
-                    OS);
-      break;
     case CounterMappingRegion::SkippedRegion:
       assert(Count.isZero());
       encodeULEB128(unsigned(I.Kind)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4677.11895.patch
Type: text/x-patch
Size: 1839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140725/d06e23cf/attachment.bin>


More information about the llvm-commits mailing list