[llvm] r213892 - [X86] Optimize stackmap shadows on X86.

[Lang Hames]

Oh - I remember now: Branch relaxation only runs during object emission. If
we waited until relaxation to fix the shadows, then the shadow optimization
wouldn't run when you're outputting assembly files. The idea that you could
get different output by passing -S vs -c seemed too non-obvious, so I came
up with the current solution.

Cheers,
Lang.


On Thu, Jul 24, 2014 at 4:39 PM, Lang Hames <lhames at gmail.com> wrote:

> Hi Joerg,
>
> I believe there is a perfectly good reason that I didn't use the branch
> relaxation code for this. I've just completely forgotten what it is. (Cards
> on the table - I wrote this patch a while back and have been sitting on it
> while I dealt with some other JIT bugs.)
>
> Let me go figure it out again...
>
> Cheers,
> Lang.
>
>
>
> On Thu, Jul 24, 2014 at 4:33 PM, Joerg Sonnenberger <
> joerg at britannica.bec.de> wrote:
>
>> On Thu, Jul 24, 2014 at 03:49:05PM -0700, Eric Christopher wrote:
>> > So you've create an EmitAndCountInstruction that you use for
>> > everything except nop... since it looks like this stuff is more
>> > multiplatform than just x86, why not generalize this out to the
>> > AsmPrinter level (other than the fact that x86 is the only variable
>> > length instruction set architecture we have?). Also, why not nop?
>>
>> In fact, we already have logic for this -- the branch relaxation code.
>>
>> Joerg
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/6ed317af/attachment.html>