[llvm] r213892 - [X86] Optimize stackmap shadows on X86.

Chandler Carruth chandlerc at google.com
Thu Jul 24 15:07:26 PDT 2014


On Thu, Jul 24, 2014 at 3:01 PM, Philip Reames <listmail at philipreames.com>
wrote:

> Ah, it seems I wasn't careful enough about my wording.
>
> I was NOT trying to say this should have been pre-reviewed.
>
> I was trying to ask a honest question: did I miss a review thread?  If so,
> I need to update my filters to highlight it.  If it was reviewed, I would
> have liked to have seen it.  This is not the same as saying it should have
> been prereviewed.
>

Ah! And yes, that comment makes *perfect* sense, including with what you
said.

Yay email communication being hard.


>
> Chandler, thanks for pointing out how my wording could be interpreted.
> Lang, sorry if my wording seemed to imply criticism.
>

NP, glad it got sorted.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/bffe027d/attachment.html>


More information about the llvm-commits mailing list