[llvm] r213892 - [X86] Optimize stackmap shadows on X86.

Chandler Carruth chandlerc at google.com
Thu Jul 24 14:41:44 PDT 2014


On Thu, Jul 24, 2014 at 2:36 PM, Philip Reames <listmail at philipreames.com>
wrote:

> Was there a review thread for this I missed?  I would have liked to see
> this before it went in.


I'm curious, why?

Lang has touched the stack map code several times before, and has touched
other parts of the other backend plenty of times. It seems plausible that
this fell into what he felt was "obvious" enough for post-commit review.
I'd like to understand what about this you feel is sufficiently non-obvious
to really need pre-commit review. (I can imagine possibilities, but that
usually isn't wise...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/23e14d7f/attachment.html>


More information about the llvm-commits mailing list