[patch] Support .warning directive in integrated assembler

Nico Weber thakis at chromium.org
Thu Jul 24 09:35:03 PDT 2014


On Thu, Jul 24, 2014 at 9:21 AM, Saleem Abdulrasool <compnerd at compnerd.org>
wrote:

> On Wed, Jul 23, 2014 at 10:43 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> I just realized that I forgot to svn add the test. Here's the same patch
>> again with a test.
>>
>
> The last two lines are duplicating the first test (in the test).  With
> that removed, LGTM.
>

r213873, thanks!


>
>
>>
>> On Wed, Jul 23, 2014 at 8:10 PM, Nico Weber <thakis at chromium.org> wrote:
>>
>>> Hi,
>>>
>>> the attached patch adds support for `.warning "optional string"`,
>>> PR20428. Ok?
>>>
>>> Like I said on the bug, it would be a nice-to-have if there'd be some
>>> clang driver option to disable .warning warnings, like there is for
>>> #warning preprocessor lines. I didn't see any infrastructure for
>>> dispatching warnings from the assembler layer to the clang driver layer
>>> though – did I just miss that? If not, are there plans to add something
>>> like that?
>>>
>>> Thanks,
>>> Nico
>>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/258d7b7c/attachment.html>


More information about the llvm-commits mailing list