PPC32 TLS (Local Dynamic, General Dynamic)

Justin Hibbits chmeeedalf at gmail.com
Wed Jul 23 17:08:12 PDT 2014


Hi Hal,

Thanks to you and Bill for reviewing.  I've attached the latest patch
which I think addresses everything.

- Justin

On Wed, 23 Jul 2014 16:14:48 -0500
Hal Finkel <hfinkel at anl.gov> wrote:

> Justin,
> 
> Just one thing on top of Bill's comments:
> 
>  def PPC32GOT: Pseudo<(outs gprc:$rD), (ins), "#PPC32GOT", 
> 
>                  [(set i32:$rD, (PPCppc32GOT))]>;
> 
> +def PPC32PICGOT: Pseudo<(outs gprc:$rD, gprc:$rT), (ins),
> "#PPC32PICGOT", 
> 
> +                []>, NoEncode<"$rT">;
> 
> Please add a comment here explaining the extra output register. Our
> invented-on-IRC trickery to get an extra allocated scratch register
> might be confusing to future generations otherwise ;)
> 
>  -Hal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc32tls_jul23.diff
Type: text/x-patch
Size: 24717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140723/47a29582/attachment.bin>


More information about the llvm-commits mailing list